Skip to content

[release/10.0.3xx] Fix DownloadBlobAsync_RetriesOnFailure digest validation #55543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nagilson wants to merge 2 commits into
base: release/10.0.3xx
Choose a base branch
from
+6 −3
Open

[release/10.0.3xx] Fix DownloadBlobAsync_RetriesOnFailure digest validation #55543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b014152
Fix DownloadBlobAsync_RetriesOnFailure: use real content digest
nagilson Jul 30, 2026
6bfb3e4
Align container digest tests with backflow fix
nagilson Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/Microsoft.NET.Build.Containers.UnitTests/RegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,15 +553,18 @@ public async Task DownloadBlobAsync_RetriesOnFailure()
var logger = _loggerFactory.CreateLogger(nameof(DownloadBlobAsync_RetriesOnFailure));

var repoName = "testRepo";
var descriptor = new Descriptor(SchemaTypes.OciLayerGzipV1, "sha256:testdigest1234", 1234);
// The digest must be the actual SHA-256 of the response bytes so that the internal
// branch's CopyToAndVerifyAsync digest validation passes after the download succeeds.
var responseBytes = new byte[] { 1, 2, 3 };
var descriptor = new Descriptor(SchemaTypes.OciLayerGzipV1, "sha256:039058c6f2c0cb492c533b0a4d14ef77cc0f78abccced5287d84a1a2011cfb81", 1234);
var cancellationToken = CancellationToken.None;

var mockRegistryAPI = new Mock<IRegistryAPI>(MockBehavior.Strict);
mockRegistryAPI
.SetupSequence(api => api.Blob.GetStreamAsync(repoName, descriptor.Digest, cancellationToken))
.ThrowsAsync(new Exception("Simulated failure 1")) // First attempt fails
.ThrowsAsync(new Exception("Simulated failure 2")) // Second attempt fails
.ReturnsAsync(new MemoryStream(new byte[] { 1, 2, 3 })); // Third attempt succeeds
.ReturnsAsync(new MemoryStream(responseBytes)); // Third attempt succeeds

Registry registry = new(repoName, logger, mockRegistryAPI.Object, null, () => TimeSpan.Zero);

Expand Down Expand Up @@ -593,7 +596,7 @@ public async Task DownloadBlobAsync_ThrowsAfterMaxRetries()
var logger = _loggerFactory.CreateLogger(nameof(DownloadBlobAsync_ThrowsAfterMaxRetries));

var repoName = "testRepo";
var descriptor = new Descriptor(SchemaTypes.OciLayerGzipV1, "sha256:testdigest1234", 1234);
var descriptor = new Descriptor(SchemaTypes.OciLayerGzipV1, "sha256:a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0c1d2e3f4a5b6c7d8e9f0a1b2", 1234);
var cancellationToken = CancellationToken.None;

var mockRegistryAPI = new Mock<IRegistryAPI>(MockBehavior.Strict);
Expand Down
Loading