Remove IdentityModel source-build workaround - #55557
Open
mthalman wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d769c502-f3c6-4f02-9e0d-db729faebcb4
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run sdk-source-build |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a temporary source-build-only IdentityModelVersion MSBuild property override for the aspnetcore source-build repository project now that the upstream aspnetcore fix has flowed into this branch.
Changes:
- Drop
/p:IdentityModelVersion=8.19.2from the source-onlyBuildArgspassed to aspnetcore builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ellahathaway
approved these changes
Jul 31, 2026
akoeplinger
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aspnetcore fix that made the IdentityModel version override unnecessary has flowed into this branch. Remove the temporary source-only
IdentityModelVersionpin so aspnetcore uses its repository-defined version again.Fixes dotnet/source-build#5617