Add linux-armel RID support for NativeAOT, crossgen2 and apphost - #55766
Open
ashaurtaev wants to merge 1 commit into
Open
Add linux-armel RID support for NativeAOT, crossgen2 and apphost#55766ashaurtaev wants to merge 1 commit into
ashaurtaev wants to merge 1 commit into
Conversation
ashaurtaev
requested review from
a team,
MiYanni and
MichaelSimons
as code owners
August 13, 2026 07:12
MichaelSimons
requested review from
mthalman
and removed request for
MichaelSimons
August 13, 2026 13:20
mthalman
reviewed
Aug 13, 2026
| switch (architectureStr) | ||
| { | ||
| case "arm": | ||
| case "armel": |
Member
There was a problem hiding this comment.
Having this simply map to Architecture.Arm will cause --target-arch:arm to be used when calling the crossgen2 tool downstream, not --target-arch:armel.
| "amd64" => "x64", | ||
| "x386" => "x86", | ||
| "arm" => $"arm{(platform.variant != "v7" ? platform.variant : "")}", | ||
| "armel" => "armel", |
Member
There was a problem hiding this comment.
In OCI, armel is typically represented as the following:
{
"os": "linux",
"architecture": "arm",
"variant": "v5"
}So it wouldn't match on armel. Instead this method would end up returning linux-armv5 which is not what you'd want. You would need to special-case the arm v5 architecture so that it returns armel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @dotnet/samsung