fix: omit browser/dynamic-variant attrs when at defaults#31
Merged
Conversation
The web component validates `browser` with ZodMiniBoolean. HTML attributes are
always strings, so `getAttribute("browser")` returns "true" (string), which
ZodMini rejects. `safeParse` fails and the component falls back to
`{viewId: "index"}`, causing every diagram on the page to render the same view.
Omitting the attribute when it equals the default means `getAttribute` returns
null, which the component converts to undefined via `?? void 0`, allowing Zod's
own default to apply correctly.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
thanks, seems reasonable as a workaround until likec4 releases a version with the fix. see also #27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web component validates
browserwith ZodMiniBoolean. HTML attributes are always strings, sogetAttribute("browser")returns "true" (string), which ZodMini rejects.safeParsefails and the component falls back to{viewId: "index"}, causing every diagram on the page to render the same view.Omitting the attribute when it equals the default means
getAttributereturns null, which the component converts to undefined via?? void 0, allowing Zod's own default to apply correctly.