Skip to content

Conversation

@maread99
Copy link
Collaborator

@maread99 maread99 commented Feb 1, 2024

Hi Doug, just a small PR to fix a couple of deprecation warnings that have cropped up with pandas 2.2.

The changes are all backwards compatible with earlier pandas versions.

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (399284b) to head (ed16dec).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   93.81%   92.89%   -0.93%     
==========================================
  Files          15       15              
  Lines        1359     1380      +21     
==========================================
+ Hits         1275     1282       +7     
- Misses         84       98      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

maread99 added a commit to maread99/market_prices that referenced this pull request Feb 13, 2024
Captures `FutureWarning` raised by `yahooquery` whilst fix
pending merging and release
(dpguthrie/yahooquery#262).
maread99 added a commit to maread99/market_prices that referenced this pull request Feb 15, 2024
Captures `FutureWarning` raised by `yahooquery` whilst fix
pending merging and release
(dpguthrie/yahooquery#262).
@cmjordan42
Copy link

I'm not familiar with the deployment cadence/process, but I've also been dealing with these warnings for months and it seems this isn't making it into the release pipeline. Is that because the code coverage decreased? I also see #273 which would address this but failed to build. Or is it a general hiatus on the project?

@SauersML
Copy link

@cmjordan42 It's not ideal, but in the meantime, you can use my fork: https://github.com/ScottSauers/yahooquery.

It fixed the warnings for me.

@galashour
Copy link

hi, just checking if this issue is still actively tracked in order to resolve the pandas deprecation messages, or if it is on hold due to some challenges. Thanks

@maread99
Copy link
Collaborator Author

Hi @galashour, I'm not aware of any reason why this couldn't be merged,

@dpguthrie, any chance of getting this merged to fix the deprecation warnings?

@maread99
Copy link
Collaborator Author

Fixed in v2.4.0 by #316

@maread99 maread99 closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants