Open
Conversation
On win32 with cmake, the visual studio sln wants dynamic but only knows about the static lib. This prevents cmake from causing trouble. https://stackoverflow.com/a/56113457/2392520 https://stackoverflow.com/a/28902261/2392520
Is a noop for shared libs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake touch ups for portability with MSVC (gross, I know).
BOOST_ALL_NO_LIBfixes weird dynamic vs static linking issues (see this and this)SHAREDinadd_library, the user gains control via theBUILD_SHARED_LIBSoption.<boost/asio.hpp>and<boost/function.hpp>are included in the public interface, boost includes need to be public, not private (could use PIMPL or maybe forward decl + pointers, but refactor didn't seem worth it)I wanted the static lib option because building DLLs is a pain. tl;dr GCC exports all symbols by default, MSVC does not. Thought about adding the infrastructure to handle this, but didn't seem worth it.