feat: detect WiFi SSID in WSL using netsh.exe#389
Merged
Conversation
Contributor
Author
|
@ethancedwards8 is this PR ready to merge ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkpluginiw devcannot see WiFi hardware since WSL virtualizes the network interface as ethernet/proc/versionand queries the Windows host's WiFi SSID usingnetsh.exeChanges
scripts/network.sh: Added WSL detection in the Linux case ofget_ssid()— if/proc/versioncontains "microsoft" andnetsh.exeis available, it usesnetsh.exe wlan show interfacesto get the SSID. Falls back to the existingiw devlogic otherwise.Testing
Tested on WSL2 Ubuntu. WiFi SSID is correctly detected and displayed with the wifi label. Non-WSL Linux behavior is unchanged (falls through to
iw dev).