Skip to content

Conversation

@dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Nov 30, 2025

Relevant to #6137

  1. Spit tagbyte union<uint8, struct{bitfields}> into just two bitfields
  2. Remove some unused functions
  3. Rename Cmp function, add dchecks

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
@dranikpg dranikpg marked this pull request as ready for review December 7, 2025 07:35
@romange
Copy link
Collaborator

romange commented Dec 11, 2025

I do not know why you did not like the tagbyte union trick.

@dranikpg
Copy link
Contributor Author

I do not know why you did not like the tagbyte union trick

Its nice for flags, but not for fields that are not connected in any way. I will destruct those unions and will keep only one in the key

@dranikpg dranikpg merged commit e32a4ed into dragonflydb:main Dec 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants