Added DrevOps PHPCS standard and fixed violations.

[AlexSkrypnyk]

Summary by CodeRabbit

• Chores

  • Enhanced code quality standards with new static analysis rules integration
  • Updated development tooling and code analysis scripts for improved workflow efficiency

• Tests

  • Refactored internal test structure for consistency

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Added phpcs standard dependency to project configuration, integrated DrevOps rule into phpcs settings, modified rector script commands to remove cache-clearing flags, and refactored test variable names to adopt snake_case naming convention across multiple test files.

Changes

Cohort / File(s)	Summary
Dependency and Configuration Updates composer.json, phpcs.xml	Added "drevops/phpcs-standard" as development dependency; updated lint and lint-fix scripts to remove --clear-cache flag from rector commands; integrated DrevOps rule reference into phpcs ruleset configuration.
Test Variable Refactoring tests/phpunit/Unit/ApiServerContextTest.php, tests/phpunit/Unit/PhpServerContextTest.php	Renamed test local variables from camelCase to snake_case convention (e.g., $reflectionClass → $reflection_class, $isRunningMethod → $is_running_method, $createHttpClient → $create_http_client) with corresponding method invocation updates. No functional or behavioral changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify that "drevops/phpcs-standard" dependency is compatible with existing project versions
• Confirm DrevOps rule reference integration does not conflict with existing phpcs rules
• Spot-check variable renames across test files for consistency and completeness

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main changes: adding DrevOps PHPCS standard (phpcs.xml modification) and fixing violations (variable naming, dependency updates, lint script changes).
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/add-cs

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d2814b and 599ff31.

📒 Files selected for processing (4)

• composer.json (2 hunks)
• phpcs.xml (1 hunks)
• tests/phpunit/Unit/ApiServerContextTest.php (5 hunks)
• tests/phpunit/Unit/PhpServerContextTest.php (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

tests/phpunit/Unit/PhpServerContextTest.php (1)

src/DrevOps/BehatPhpServer/PhpServerContext.php (1)

• PhpServerContext (18-683)

tests/phpunit/Unit/ApiServerContextTest.php (1)

src/DrevOps/BehatPhpServer/ApiServerContext.php (2)

• ApiServerContext (20-393)
• apiWillRespondWithJson (191-198)

🪛 PHPMD (2.15.0)

tests/phpunit/Unit/PhpServerContextTest.php

69-69: Missing class import via use statement (line '69', column '29'). (undefined)

(MissingImport)

---

69-69: The variable $reflection_class is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

70-70: The variable $is_running_method is not named in camelCase. (undefined)

(CamelCaseVariableName)

tests/phpunit/Unit/ApiServerContextTest.php

42-42: Missing class import via use statement (line '42', column '29'). (undefined)

(MissingImport)

---

42-42: The variable $reflection_class is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

43-43: The variable $create_http_client is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

47-47: The variable $additional_options is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

89-89: Missing class import via use statement (line '89', column '29'). (undefined)

(MissingImport)

---

89-89: The variable $reflection_class is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

90-90: The variable $prepare_response is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

94-94: The variable $json_input is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

182-182: Missing class import via use statement (line '182', column '29'). (undefined)

(MissingImport)

---

182-182: The variable $reflection_class is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

183-183: The variable $prepare_response is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

187-187: The variable $exception_class is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

189-189: The variable $exception_message is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

190-190: The variable $json_input is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

242-242: The variable $py_string_node is not named in camelCase. (undefined)

(CamelCaseVariableName)

---

242-242: The variable $json_content is not named in camelCase. (undefined)

(CamelCaseVariableName)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: PHP 8.3 on macos-latest
• GitHub Check: PHP 8.2 on macos-latest
• GitHub Check: PHP 8.4 on macos-latest

🔇 Additional comments (8)

phpcs.xml (1)

9-9: LGTM!

The DrevOps PHPCS standard is correctly added and aligns with the new dependency in composer.json.

composer.json (2)

30-30: LGTM!

The drevops/phpcs-standard dependency is correctly added to support the new DrevOps rule in phpcs.xml.

---

68-72: LGTM!

Removing --clear-cache from the rector commands is a sensible optimization—cache clearing on every run is unnecessary and slows down routine linting.

tests/phpunit/Unit/PhpServerContextTest.php (1)

69-74: LGTM!

The variable renames to snake_case align with Drupal/DrevOps coding standards. The PHPMD warnings for camelCase are false positives in this context—Drupal standards use snake_case for local variables. The \ReflectionClass FQCN usage is also valid; importing built-in PHP classes is optional.

tests/phpunit/Unit/ApiServerContextTest.php (4)

42-47: LGTM!

Variable renames to snake_case follow Drupal/DrevOps coding standards. The PHPMD camelCase warnings are false positives for this codebase.

---

89-94: LGTM!

Consistent snake_case variable naming applied to the reflection setup.

---

182-190: LGTM!

Snake_case naming consistently applied.

---

242-259: LGTM!

Variable rename from $pyStringNode to $py_string_node follows the adopted coding standard, and the method invocation is correctly updated.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (6d2814b) to head (599ff31).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files           3        3           
  Lines         430      430           
=======================================
  Hits          324      324           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.