Skip to content

Comments

Added PHP 8.5 to GHA.#50

Merged
AlexSkrypnyk merged 1 commit intomainfrom
feature/php85
Nov 25, 2025
Merged

Added PHP 8.5 to GHA.#50
AlexSkrypnyk merged 1 commit intomainfrom
feature/php85

Conversation

@AlexSkrypnyk
Copy link
Member

@AlexSkrypnyk AlexSkrypnyk commented Nov 25, 2025

Summary by CodeRabbit

  • Chores
    • Extended automated testing to include PHP 8.5 alongside existing supported versions (8.2, 8.3, 8.4).

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

📝 Walkthrough

Walkthrough

The PHP test matrix in the GitHub Actions workflow was expanded to include PHP 8.5 alongside existing versions 8.2, 8.3, and 8.4. No other workflow steps or logic were modified.

Changes

Cohort / File(s) Summary
PHP Test Workflow Updates
\.github/workflows/test-php\.yml
Extended the PHP versions matrix to include PHP 8.5 for testing

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Added PHP 8.5 to GHA' directly and clearly describes the main change: adding PHP 8.5 to GitHub Actions workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/php85

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48c6142 and 6445cd3.

📒 Files selected for processing (1)
  • .github/workflows/test-php.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: PHP 8.4 on macos-latest
  • GitHub Check: PHP 8.5 on macos-latest
  • GitHub Check: PHP 8.3 on macos-latest
  • GitHub Check: PHP 8.2 on macos-latest
🔇 Additional comments (1)
.github/workflows/test-php.yml (1)

25-25: PHP 8.5 support is confirmed and technically ready.

PHP 8.5 was released on November 20, 2025, and the shivammathur/setup-php action supports PHP 8.5. The workflow will not fail due to unavailable PHP versions or action incompatibility.

Before merging, verify that your project's dependencies (in composer.json) are compatible with PHP 8.5. Since your workflow has fail-fast: false, PHP 8.5 job failures won't block the entire matrix, but you should ensure tests pass on the new version.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.34%. Comparing base (48c6142) to head (6445cd3).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files           3        3           
  Lines         430      430           
=======================================
  Hits          324      324           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit d50238d into main Nov 25, 2025
12 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/php85 branch November 25, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant