-
Notifications
You must be signed in to change notification settings - Fork 13
0.4.12 #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiajic
wants to merge
27
commits into
main
Choose a base branch
from
staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
0.4.12 #336
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c23ff68
fix outdated argument for seurat object and fix typo
josschavezf b73ac46
Merge pull request #326 from josschavezf/dev
josschavezf 181bc69
upgrade R version
josschavezf 5e1da1e
replace = -> assingment symbol
josschavezf 200183b
fix indentation
josschavezf 00ef247
run devtools::document
josschavezf dba4dac
Merge pull request #327 from josschavezf/dev
josschavezf e131ff1
Add functionality to read OME Map Annotations (K/Vs) (tif_metadata)
iqraAmin 77ccdd4
Merge pull request #328 from iqraAmin/dev
jiajic 66eca1c
fix: typo
wwang-chcn 9d8dce4
Merge pull request #330 from wwang-chcn/dev
jiajic 62c2418
slot checking changes
jiajic 9790ce4
chore: docs
jiajic f6e8fdc
fix: tests now align with changes
jiajic 1ef5eaf
Merge pull request #331 from jiajic/slot_checks_update
jiajic 451e35a
new: misc slot for unstructured data
jiajic af288d9
Merge pull request #332 from jiajic/misc_patch
jiajic e86adc6
require misc to be a list
jiajic bbc3983
Merge pull request #333 from jiajic/misc_patch
jiajic f77f34f
fix numeric_version() and numeric incompat
jiajic 8bf876f
run devtools::document
josschavezf 824c1e4
Merge pull request #334 from josschavezf/dev
josschavezf 9dcbb81
fix: automatically use count column if present
jiajic 937fa30
enh: autodetect "count" col in feature points
jiajic b3b2294
chore: docs
jiajic c7af931
conflict fix
jiajic 54b25ad
Merge pull request #335 from drieslab/dev
jiajic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -152,7 +152,7 @@ evaluate_input <- function(type, x, ...) { | |
| .gstop( | ||
| "expression input needs to be a path to matrix-like data or an", | ||
| "object of class 'Matrix', 'data.table', 'data.frame', 'matrix'", | ||
| "'DelayedMatrix' or 'dbSparseMatrix'." | ||
| "'DelayedMatrix' or 'dbSparseMatrix'." | ||
| ) | ||
|
Comment on lines
152
to
156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Align the error message with supported classes ( - "'DelayedMatrix' or 'dbSparseMatrix'."
+ "'DelayedMatrix' or 'dbMatrix'."🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
|
|
@@ -321,7 +321,7 @@ evaluate_input <- function(type, x, ...) { | |
| rnames <- rownames(x) | ||
| if (!is.null(rnames)) { | ||
| vmsg(.v = verbose, "[spatlocs] matrix input has rownames. | ||
| Using these as IDs.") | ||
| Using these as IDs.") | ||
| dt[, id := rnames] | ||
| } | ||
| .evaluate_spatial_locations(dt, verbose = verbose, ...) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Count-column autodetect should key off
y[](SpatVector) to avoidnames()method ambiguity.Right now detection uses
names(y)while the actual downstream overlap runs ony[]. Ifnames(giottoPoints)ever diverges fromnames(giottoPoints[]), autodetect can misfire.📝 Committable suggestion
🤖 Prompt for AI Agents