fix(pg): restore lazy evaluation of $onUpdate callbacks in buildUpdateSet#5781
Open
hognevevle wants to merge 1 commit into
Open
fix(pg): restore lazy evaluation of $onUpdate callbacks in buildUpdateSet#5781hognevevle wants to merge 1 commit into
$onUpdate callbacks in buildUpdateSet#5781hognevevle wants to merge 1 commit into
Conversation
fix(pg): restore lazy evaluation of `$onUpdate` callbacks in `buildUpdateSet` 0.45.x introduced a regression where `$onUpdate` callbacks are invoked unconditionally for every column that defines one, even when an explicit value is provided in set. The callback result is then discarded via `??`, but side effects in the callback always fire. Restores the pre-0.45 behaviour: the callback is only invoked when the column is absent from set. Fixes drizzle-team#5780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.45.x introduced a regression where
$onUpdatecallbacks are invoked unconditionally for every column that defines one, even when an explicit value is provided in set. The callback result is then discarded via??, but side effects in the callback always fire.Restores the pre-0.45 behaviour: the callback is only invoked when the column is absent from set.
Fixes #5780