fix: type isNull and isNotNull as boolean in select queries#5799
Open
emreyn1 wants to merge 1 commit into
Open
fix: type isNull and isNotNull as boolean in select queries#5799emreyn1 wants to merge 1 commit into
emreyn1 wants to merge 1 commit into
Conversation
Both helpers can produce NULL at the SQL level (e.g. `NULL IS NULL` is unknown in some dialects/contexts), so widening the return type to include `null` reflects what actually comes back. Scope kept minimal to isNull/isNotNull — happy to close in favor of drizzle-team#5226 if that lands first. Fixes drizzle-team#1826
emreyn1
force-pushed
the
fix/condition-expression-boolean-types
branch
from
12939de to
31b08dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1826. Minimal scope: only isNull/isNotNull return SQL<boolean | null>. Note: related to open #5226 - happy to close in favor of that if maintainers prefer.