[Orm] Skip executing fully-commented introspect migration files#5812
Open
youcefzemmar wants to merge 1 commit into
Open
Conversation
youcefzemmar
commented
May 27, 2026
`drizzle-kit pull` writes the discovered schema into the next migration file wrapped in a single `/* ... */` block with two `--` notes above it, expecting the user to uncomment before running `migrate`. When the user leaves it commented (intentionally, as a baseline), `migrate` crashes the underlying driver with a parse error on the comment delimiters. Detect this exact shape in `readMigrationFiles` — `--` lines + a single balanced `/* ... */` body with no nested `*/` — and treat such entries as zero-statement migrations. The hash row still gets inserted into `__drizzle_migrations`, so the baseline is recorded as applied. Normal multi-statement files and any file that contains real SQL outside the block are unchanged. Fixes drizzle-team#4851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.