WIP: Update bintray plugin format for 1.x.x compatibility#25
WIP: Update bintray plugin format for 1.x.x compatibility#25arcolife wants to merge 2 commits intodrone-plugins:masterfrom
Conversation
- json -> yaml: add yaml based config parser
- add forked bintray go client as dep
- godotenv mod to parse configs from .env / env vars all the same
- update documentation
arcolife
force-pushed
the
update-for-1.x.x
branch
from
aace7e9 to
2aadfd1
Compare
tboerger
left a comment
tboerger
left a comment
There was a problem hiding this comment.
I haven't reviewed reviewed now,but at least that's a starting point
| @@ -0,0 +1,8 @@ | |||
| BINTRAY_KEY=f4g8ef@***223 | |||
There was a problem hiding this comment.
This is only temporary for testing, right?
| coverage.out | ||
| drone-bintray | ||
|
|
||
| *~ |
There was a problem hiding this comment.
This looks like editor specific ignores, you should add that to your local global gitignore.
| @@ -1,7 +1,12 @@ | |||
| module github.com/drone-plugins/drone-bintray | |||
| module github.com/arcolife/drone-bintray | |||
There was a problem hiding this comment.
That should be drone-plugins
| &cli.IntFlag{ | ||
| Name: "bintray.threads,t", | ||
| Usage: "bintray threads", | ||
| EnvVars: []string{"PLUGIN_BINTRAY_THREADS", "BINTRAY_THREADS"}, |
There was a problem hiding this comment.
As this is the bintray plugin please name them PLUGIN_ instead of PLUGIN_BINTRAY_
| } | ||
|
|
||
| func (config *BintrayConfig) deleteRepo(btManager *bintray.ServicesManager, repo *Repo) error { | ||
| fmt.Printf("\nDeleting Repo.. [%s]\n", repo.Name) |
There was a problem hiding this comment.
With all these log messages you should use a structured logger like logrus, we will anyway use it more within plugins as it's part of our upcoming plugin lib
There was a problem hiding this comment.
right for some reason logger built in jfrog go library of bintray wasn't working. I was hoping to reuse that tho
| // files []string | ||
| // ) | ||
| // fmt.Printf("Drone Bintray Plugin built from %s\n", p.Version) | ||
| cSig := make(chan os.Signal) |
There was a problem hiding this comment.
We aren't doing that for any plugin and I can't clearly see why we should introduce that here.
arcolife
force-pushed
the
update-for-1.x.x
branch
from
d07b8c6 to
8cc8564
Compare
2 participants
Add following for new bintray dep:
Removed artifactory and will re-add once the above workflow is validated. For this very reason, I'm using a fork of: https://github.com/jfrog/jfrog-client-go -> github.com/arcolife/jfrog-client-go
The fork is waiting to be merged into master at jfrog/jfrog-client-go#103
@tboerger @bradrydzewski A rather delayed follow up from our discussion on gitter earlier at https://gitter.im/drone/plugins?at=5d7fd98572fe125111b77576 😄
TODO:
package_config.yamlhere should be 1. So to speak, bintray doesn't accept multiple file uploads in 1 go. Else threads > 1 almost always fails to upload to bintray, the first time jfrog/jfrog-client-go#107