Skip to content

Implement xsd:integer codec#73

Merged
mark-dropbear merged 3 commits intomainfrom
integer
Nov 27, 2025
Merged

Implement xsd:integer codec#73
mark-dropbear merged 3 commits intomainfrom
integer

Conversation

@mark-dropbear
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces full support for the xsd:integer XML Schema Definition datatype within the library. It provides a robust codec that accurately converts between string representations and Dart's BigInt objects, adhering to XSD specifications for integer parsing, including whitespace collapse. This enhancement significantly broadens the library's capability to correctly process integer values as defined by XML Schema standards.

Highlights

  • New xsd:integer Codec: A new XsdIntegerCodec has been implemented to handle the xsd:integer datatype, enabling conversion between string representations and Dart's BigInt type.
  • Documentation Update: The README.md has been updated to reflect full support (encoding and decoding) for the xsd:integer datatype.
  • Comprehensive Testing: Dedicated unit tests have been added for the XsdIntegerCodec, covering various scenarios including valid integer parsing, whitespace handling, and error cases for invalid inputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the xsd:integer codec, including the encoder, decoder, and tests. The implementation is clean and follows the project's structure. I've added a few suggestions to improve code style consistency, remove unused imports, and enhance test coverage for edge cases. Overall, great work!

Comment on lines +22 to +23
expect(() => codec.decode('12.3'), throwsFormatException);
expect(() => codec.decode('abc'), throwsFormatException);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve test coverage, it would be good to add test cases for empty and whitespace-only strings, as these are important edge cases for the decoder.

      expect(() => codec.decode('12.3'), throwsFormatException);
      expect(() => codec.decode('abc'), throwsFormatException);
      expect(() => codec.decode(''), throwsFormatException);
      expect(() => codec.decode('   '), throwsFormatException);

mark-dropbear and others added 2 commits November 27, 2025 14:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mark-dropbear mark-dropbear merged commit b40f9f6 into main Nov 27, 2025
1 check passed
@mark-dropbear mark-dropbear deleted the integer branch November 27, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant