fix: Ensure XsdDate only accepts valid timezones

[mark-dropbear]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the XsdDate class by introducing comprehensive validation for timezone offsets during the parsing process. The primary goal is to prevent the creation of XsdDate objects with out-of-range timezone information, thereby improving data integrity and ensuring compliance with standard date-time representations. This change includes both the implementation of the validation logic and corresponding test cases.

Highlights

• Timezone Validation: Implemented stricter validation for timezone offsets in the XsdDate.parse method, ensuring that the hours component does not exceed 14 and the minutes component does not exceed 59, specifically disallowing any minutes when the hour component is exactly 14 (as the maximum valid offset is +/-14:00).
• Error Handling: A FormatException is now explicitly thrown when an invalid timezone offset range is detected during the parsing of an XSD date string, providing clearer error feedback.
• Test Coverage: Added new unit tests to xsd_date_test.dart to verify that XsdDate.parse correctly throws a FormatException for various invalid timezone offsets, such as +15:00 and -14:01.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fix to ensure that XsdDate only accepts valid timezone offsets by adding validation for the hour and minute ranges. The changes are well-implemented and improve the robustness of the date parsing logic. I've added one suggestion to enhance the test coverage for the new validation, ensuring all conditions are checked.