Update the float codec to respect 32 bit precision limitations

[mark-dropbear]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mark-dropbear, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the XsdFloatDecoder to strictly adhere to the 32-bit precision requirements for XSD float types. This ensures that any double value parsed from a string is first converted to its 32-bit float representation, with appropriate error handling for values that exceed or fall below the 32-bit range, thereby preventing potential precision mismatches or incorrect interpretations.

Highlights

• 32-bit Precision Enforcement: The XsdFloatDecoder now explicitly rounds decoded float values to 32-bit precision using Float32List before returning them, aligning with XSD float specifications.
• Overflow and Underflow Validation: Improved validation logic ensures that values causing overflow (becoming infinity) or underflow (becoming zero from a non-zero original) when rounded to 32-bit are correctly identified and throw FormatException.
• Test Case Updates: Existing test cases for float decoding have been updated to reflect the new 32-bit precision behavior, comparing decoded values against their Float32List rounded equivalents.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the float codec to respect 32-bit precision limitations by returning the rounded value instead of the original 64-bit double. The changes in the implementation are correct and well-tested. I've added a minor suggestion to improve the readability and maintainability of the test code.