fix(subtitle): handle VTT positioning directives in subtitle parsing#19
Open
abdelaziz-mahdy wants to merge 2 commits intodsc-uob:masterfrom
Open
fix(subtitle): handle VTT positioning directives in subtitle parsing#19abdelaziz-mahdy wants to merge 2 commits intodsc-uob:masterfrom
abdelaziz-mahdy wants to merge 2 commits intodsc-uob:masterfrom
Conversation
Subtitle load failures used to vanish into zone error handlers — the provider fire-and-forgets `initial()`, so a bad URL, non-200, or unsupported extension produced silent "no subs rendered" with no breadcrumbs. Now every fetch logs url/scheme/host/extension/header-keys, every response logs status + body head, every exception logs with stack, every zero-match parse logs body head + detected type, and UnsupportedSubtitleFormat logs the rejected extension. Uses `dart:developer.log(name: 'subtitle')` so nothing new shows up for consumers by default — only when they attach DevTools or tail `flutter run` output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of VTT subtitle parsing in the
SubtitleParserclass to better support VTT-specific directives. The main change is to ensure that positioning and styling directives in VTT subtitle lines are skipped, so only the actual subtitle text is extracted.Subtitle parsing improvements:
SubtitleParserlogic to detect VTT directives (e.g.,line,align,position, etc.) in group 10 and, when present, extract subtitle text from group 11 instead. This prevents directives from being misinterpreted as subtitle text.Test case update:
line: 20%directive, ensuring the parser correctly skips the directive and extracts only the subtitle text.