Fixes (spacing) bug in home page#63
Open
caseymhunt wants to merge 1 commit intodscabesit:masterfrom
caseymhunt:issue-61
Open
Fixes (spacing) bug in home page#63caseymhunt wants to merge 1 commit intodscabesit:masterfrom caseymhunt:issue-61
caseymhunt wants to merge 1 commit intodscabesit:masterfrom
caseymhunt:issue-61
Conversation
A fixed height was set on all `.section` elements in combination with a `padding-top` set on the first content section causes a content overrun on smaller screens. Removes fixed height, adds padding to `.section`, and removes inline `padding-top`
caseymhunt
commented
Oct 5, 2020
Author
caseymhunt
left a comment
caseymhunt
left a comment
There was a problem hiding this comment.
Additional line edits are the result of syntax linting and should increase readability of the code.
Author
|
Any issues with merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #61
A fixed height was set on all
.sectionelements in combination with apadding-topset on the first content section causes a content overrunon smaller screens.
Removes fixed height, adds padding to
.section, and removes inlinepadding-top