Skip to content

Conversation

@rdbartram
Copy link

@rdbartram rdbartram commented Nov 29, 2017

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #72 into dev will decrease coverage by <1%.
The diff coverage is 66%.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #72   +/-   ##
=================================
- Coverage   81%   80%   -1%     
=================================
  Files        5     5           
  Lines      417   418    +1     
=================================
  Hits       338   338           
- Misses      79    80    +1

@johlju johlju added the needs review The pull request needs a code review. label May 18, 2018
@johlju
Copy link
Member

johlju commented May 18, 2018

For reference: This changes is also implemented in PR #74 and being discussed in issue #78.

@johlju
Copy link
Member

johlju commented May 18, 2018

I'm closing this PR in favor for PR #74 (or if a new PR must be created depending of the discussion in #78).

@johlju johlju closed this May 18, 2018
@johlju johlju removed the needs review The pull request needs a code review. label May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants