Allow multiple delegations to stack, as well as optional prefixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscottboggs
requested changes
Jun 29, 2022
Owner
dscottboggs
left a comment
dscottboggs
left a comment
There was a problem hiding this comment.
I should've thought to enable stacking, smart idea, and thanks for making a PR for it. Just one change requested and a couple questions.
|
|
||
| _prefix = named_args.get('prefix', '') | ||
|
|
||
| print(_dest, _prefix) |
Owner
There was a problem hiding this comment.
This print call should be removed
| """Wrap the target class up in something that modifies.""" | ||
| class Wrapped(cls): | ||
|
|
||
| _delegates = [(a, _dest, _prefix) for a in args] + getattr(cls, '_delegates', []) |
Comment on lines
-40
to
-41
| def __init__(self, *wrapped_args, **wrapped_opts): | ||
| super().__init__(*wrapped_args, **wrapped_opts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to use this library for a project, but it didn't fully support some of the features I needed (delegation with prefixes and multiple calls). I generalized it to handle these cases, let me know if this is a welcome contribution :)