Skip to content

Conversation

@jonyesno
Copy link

... so that va_end comes after vsnprintf's use of ap.

Otherwise an optimising compiler can produce code that segfaults.

I don't know enough about compilers to know why, though this updated va_start -> vsnprintf -> va_end sequence feels appropriate.

Context: I was writing a FreeBSD port for tdu and it defaults to -O2 on non-debug builds.

Thanks for tdu!

otherwise `vsnsprintf` segfaults under some compiler optimisation
settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant