Fix responsive issues due to using scrollWidth instead of clientWidth…#20
Open
billschaller wants to merge 1 commit intodsmorse:masterfrom
Open
Fix responsive issues due to using scrollWidth instead of clientWidth…#20billschaller wants to merge 1 commit intodsmorse:masterfrom
billschaller wants to merge 1 commit intodsmorse:masterfrom
Conversation
… - paddingLeft - paddingRight.
|
Is there a reason why this pull request has never been merged? |
Owner
|
initially It was because it conflicted with the webcomponents.js, but that has become moot, now it's because there is a merge conflict. |
|
@billschaller I know this is an old PR but would it be possible to discard the changes made at dist? dist is used so that upstream can offer an already built package to package managers, and should reflect the state of upstream. Other PR's could've changed that state before yours so it wouldn't be right to overwrite those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… - paddingLeft - paddingRight.
el[0].scrollWidth is definitely not the same as el.width().
scrollWidth returns the larger of either the width of the container or the width of the scrolling context, which is the width of the existing content in the element. Therefore, this change completely breaks responsive containers when resizing to a smaller width. Since the width of the content is larger than the new width of the container, this is not useful for sizing responsive containers.
The changes changing el.width() to el[0].scrollWidth should all be reverted. I've been trying to track the cause of responsive issues down for weeks off and on, and finally dedicated enough time today to find this...