Skip to content

Update Sbxh parser#2796

Merged
dteviot merged 7 commits into
dteviot:ExperimentalTabModefrom
Bartuzen:sbxh
Jul 13, 2026
Merged

Update Sbxh parser#2796
dteviot merged 7 commits into
dteviot:ExperimentalTabModefrom
Bartuzen:sbxh

Conversation

@Bartuzen

@Bartuzen Bartuzen commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Made some improvements to Sbxh parser.

  • Added site's mirror domain.
  • Chapters are now fetched from all paginated chapter list pages. Previously, only the chapters visible on the currently loaded page were fetched.
  • Rather than using a broad selector to get chapter title and parsing it, I instead directly fetched the title which gives a better result.
  • Chapter title now always includes both chapter title and chapter count. Sometimes both chapter count and title can be same which results in a title like 1화 - 1화, but since title format isn't consistent, I kept it like this.

@gamebeaker

Copy link
Copy Markdown
Collaborator

@Bartuzen do you want to add yourself to the "contributors" section of packages.json and updated the "Credits" section of readme.md with your name?

Just a question out of curiosity did you use the wiki guide https://github.com/dteviot/WebToEpub/wiki/Developer-guide?

@Bartuzen

Bartuzen commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Sure, let me add my name real quick.
For the second question, no. I didn't check out wiki too much and didn't realize there was such a page.

@Bartuzen Bartuzen marked this pull request as draft July 10, 2026 06:13
@Bartuzen Bartuzen marked this pull request as ready for review July 10, 2026 19:13
Comment thread plugin/js/parsers/experimental/Sbxh1Parser.js Outdated
Bartuzen added 2 commits July 12, 2026 15:28
Otherwise it can pick random images for series that don't have a cover
@dteviot

dteviot commented Jul 13, 2026

Copy link
Copy Markdown
Owner

@Bartuzen

Apologies, but due to other MRs that got in first, can you rebase and fix package.json please.

@dteviot

dteviot commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Thank you for your contribution.

@dteviot dteviot merged commit 8caced9 into dteviot:ExperimentalTabMode Jul 13, 2026
1 check passed
@Bartuzen Bartuzen deleted the sbxh branch July 13, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants