Creates Strava transfer service class and adds configuration to base transfer service class #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborem
commented
Aug 11, 2025
| warn_return_any = true | ||
| strict_optional = true | ||
| disallow_incomplete_defs = true | ||
| exclude_gitignore = true |
Collaborator
Author
There was a problem hiding this comment.
It's set as this by default
alexbainter
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
State as arg: When adding
pardnertopardner-site, I realized it's necessary to instantiate a transfer service with an existingstatevariable defined, so I added that as an argument to the constructor.Configuring scope:
requests_oauthlibalways sends requests with scopes separated with a space, but Strava (for example) specifies the scopes need to be comma-separated.Adding default logic to base class: The
fetch_tokenandauthorization_urlmethods will almost always have the same functionality regardless of service, so I filled them out in the base class as well.Tests: extracted common test fixtures and moved some tests to base transfer service test file.