Skip to content

Conversation

@aborem
Copy link
Collaborator

@aborem aborem commented Sep 2, 2025

Closes #61

So any time we were using Vertical.SubVerticalName we now use SubVerticalName, where SubVerticalName is a subclass of BaseVertical. Note that I do mean subclass and not instance of a subclass since we're using the classes themselves as identifiers of verticals. In the future, methods will be returning instances of those same subclasses.

I also adjusted the names of the vertical fetching methods to follow the structure: fetch_<vertical_name>_vertical for consistency and to avoid having to keep track of the plural names like before.

Misc

Anywhere where an argument arg to a function/method could have one or more items, like in the constructor of the exception classes, I make these into a *arg instead so we don't have to special case passing in different number of arguments.

@aborem aborem requested a review from lisad September 2, 2025 14:55
@aborem aborem merged commit a586a7b into main Sep 2, 2025
1 check passed
@aborem aborem deleted the aborem/replace-vertical-enum branch September 2, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace references to Vertical enum in codebase with references to newly created base vertical class

3 participants