Uses subclasses of BaseVertical rather than the Vertical enum to identify a vertical
#66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
So any time we were using
Vertical.SubVerticalNamewe now useSubVerticalName, whereSubVerticalNameis a subclass ofBaseVertical. Note that I do mean subclass and not instance of a subclass since we're using the classes themselves as identifiers of verticals. In the future, methods will be returning instances of those same subclasses.I also adjusted the names of the vertical fetching methods to follow the structure:
fetch_<vertical_name>_verticalfor consistency and to avoid having to keep track of the plural names like before.Misc
Anywhere where an argument
argto a function/method could have one or more items, like in the constructor of the exception classes, I make these into a*arginstead so we don't have to special case passing in different number of arguments.