Strava fetch methods return model objects rather than Any
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborem
changed the title
Any
lisad
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
I decided to have the fetch methods return values with the following type signature:
tuple[list[<Vertical> | None], Any]. The first element in the tuple is the list of model objects that were parsed using the response from the API request. It's also possiblyNonesince there may be a parsing failure. The second element is the raw response payload, which we return in case the caller wants more data than we provide in the model definition.In this PR I wrote two Strava public methods:
fetch_social_posting_verticalandfetch_physical_activity_vertical.I also set the
BaseVertical.idfield to be self-generating.