Skip to content

Enable back extension tests on CI #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staticlibs merged 1 commit into from
Jun 25, 2026
+5 −9
Merged

Enable back extension tests on CI #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/Java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ jobs:
name: Linux Spark (amd64)
runs-on: ubuntu-latest
needs: java-linux-amd64
# todo: enable me
if: ${{ false }}
env:
MANYLINUX_IMAGE: quay.io/pypa/manylinux_2_28_x86_64
DUCKDB_JDBC_JAR: ${{ github.workspace }}/build/release/duckdb_jdbc.jar
Expand Down Expand Up @@ -849,7 +847,7 @@ jobs:
needs:
- java-linux-amd64
- java-linux-amd64-tck
# - java-linux-amd64-spark
- java-linux-amd64-spark
- java-linux-amd64-asan
- java-linux-amd64-jepsen
- java-linux-aarch64
Expand Down Expand Up @@ -934,7 +932,7 @@ jobs:
needs:
- java-linux-amd64
- java-linux-amd64-tck
# - java-linux-amd64-spark
- java-linux-amd64-spark
- java-linux-amd64-asan
- java-linux-amd64-jepsen
- java-linux-aarch64
Expand Down
5 changes: 2 additions & 3 deletions src/test/java/org/duckdb/TestDuckDBJDBC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2264,8 +2264,7 @@ public static void test_ignore_unsupported_options() throws Exception {
DriverManager.getConnection("jdbc:duckdb:;foo=bar;jdbc_ignore_unsupported_options=yes;", config).close();
}

// TODO: enable me
public static void DISABLED_test_extension_excel() throws Exception {
public static void test_extension_excel() throws Exception {
// Check whether the Excel extension can be installed and loaded automatically
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement();
ResultSet rs = stmt.executeQuery("SELECT excel_text(1_234_567.897, 'h:mm AM/PM')")) {
Expand All @@ -2287,7 +2286,7 @@ public static void main(String[] args) throws Exception {
TestAppenderCollection2D.class, TestAppenderComposite.class, TestSingleValueAppender.class,
TestBatch.class, TestBindings.class, TestChunkedResult.class, TestClosure.class,
TestExtensionTypes.class, TestJfrEvents.class, TestMetadata.class, /* TestNoLib.class ,*/
/* TestSpatial.class,*/ TestParameterMetadata.class, TestPrepare.class, TestResults.class,
TestSpatial.class, TestParameterMetadata.class, TestPrepare.class, TestResults.class,
TestScalarFunctions.class, TestSessionInit.class, TestTableFunctions.class,
TestTimestamp.class, TestVariant.class);
}
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/org/duckdb/TestVariant.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,8 @@ public static void test_variant_struct() throws Exception {
}
}

// TODO: enable me
// https://github.com/duckdb/duckdb/issues/23274
public static void DISABLED_test_variant_struct_with_variant() throws Exception {
public static void test_variant_struct_with_variant() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement()) {

stmt.execute("CREATE TABLE tab1 (col1 INTEGER, col2 STRUCT(s1 INTEGER, s2 VARIANT))");
Expand Down
Loading