Skip to content

Fixes double-decoding of event data #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrissrogers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes double-decoding of event data #70

chrissrogers wants to merge 1 commit into from

Conversation

@chrissrogers
Copy link
Contributor

@chrissrogers chrissrogers commented May 9, 2015

  • koa's query getter implements querystring#parse, which itself calls decodeURIComponent
  • if the data object passed contained a '%', the second decode here would throw a URIError.
  • to reproduce this, try putting a % sign into a test description.

@chrissrogers
Fixes double-decoding of event data
001cdfe 
- koa's [query getter](https://github.com/koajs/koa/blob/master/lib/request.js#L137) implements [querystring#parse](https://nodejs.org/api/querystring.html#querystring_querystring_parse_str_sep_eq_options), which already calls `decodeURIComponent`
- if the data object passed contained a '%', the second decode here would fail.
@chrissrogers chrissrogers mentioned this pull request May 12, 2015
Merged
@stephenmathieson
Copy link
Contributor

stephenmathieson commented May 13, 2015

travis failing??

@chrissrogers
Copy link
Contributor Author

chrissrogers commented May 13, 2015

Looks unrelated. I can't rerun save for force pushing though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrissrogers @stephenmathieson