Conversation
- Add Watchdog job that scans for stale pending workflows and recovers them - Fix Workflow re-release loop: redelivered jobs now proceed when status is Running - WorkflowStub::start() kicks watchdog as fast path - WorkflowServiceProvider registers Queue Looping listener for worker liveness - Add watchdog_timeout config option (default 300s) Agent-Logs-Url: https://github.com/durable-workflow/workflow/sessions/4624e0c2-61c6-402b-bc64-bbfbf59a9d7c Co-authored-by: rmcdaniel <1130888+rmcdaniel@users.noreply.github.com>
…eorder kick - Watchdog now refreshes workflow from DB before recovery (prevents duplicates) - Watchdog touches updated_at before re-dispatch (prevents re-scan) - Uses Cache::lock()->forceRelease() matching Laravel's UniqueLock pattern - Uses Carbon::now() instead of now() to avoid Workflow\now() namespace collision - Kick watchdog before workflow dispatch in start() (covers producer crash) - Add redelivery test, Looping listener tests, comprehensive watchdog tests Agent-Logs-Url: https://github.com/durable-workflow/workflow/sessions/3276cfde-9a62-4b33-abd7-2d821e4c8203 Co-authored-by: rmcdaniel <1130888+rmcdaniel@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 578 597 +19
===========================================
Files 62 63 +1
Lines 2005 2077 +72
===========================================
+ Hits 2005 2077 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Watchdog acts as a lightweight recovery loop for the workflow engine. If a workflow is left in
pendinglong enough that it looks stranded, the Watchdog notices it from the worker loop and safely kicks it back onto the normal resume path instead of leaving it stuck indefinitely.