Format MSSQL query logs as executable multi-line SQL with DECLARE parameter headers (including TVP support)

[Copilot]

SQL query logs were difficult to read because query text and parameters were emitted as JSON fields with escaped control characters. This updates MSSQL logging to emit readable multi-line SQL and prepend parameter DECLARE statements with inferred SQL types and correctly formatted values.

• Added SQL log formatter for { query, parameters }

  • Introduced formatSqlQueryForLog in lib/sql.js
  • Converts request parameters into DECLARE lines:
    • maps MSSQL constructors to SQL type names (INT, VARCHAR(n), DATETIME2, BIT, etc.)
    • supports length / precision / scale where present
    • formats values for SQL readability ('escaped strings', NULL, 1/0 for bit, datetime literals, hex for buffers)
  • Appends the original query verbatim, preserving real newlines/tabs

• Added TVP (mssql.Table) formatting support

  • Detects TVP parameters via instanceof mssql.Table
  • Emits executable TVP setup before scalar DECLAREs:
    • DECLARE @Param [schema].[Type] (from table.path)
    • INSERT INTO @Param ([col1], [col2], ...) VALUES (...)
  • Uses TVP column names from table.columns
  • Uses existing SQL value formatting for row values
  • Batches row inserts up to 100 rows per INSERT using multi-row VALUES

• Applied formatter at all MSSQL query log sites

  • Slow-query warning path (logSlowQuery)
  • Query threshold logger (createQueryLogger)
  • Query error logger (runQuery catch path)

• Added focused coverage for log output shape

  • New tests in tests/sql-log-format.test.js
  • Verifies:
    • scalar DECLARE generation + type/value formatting
    • TVP formatting includes type path and readable row values (not JSON dump)
    • TVP batching at 100 rows per INSERT
    • preserved multi-line query text
    • formatter usage in all three logging paths

DECLARE @ListParam [dbo].[StringList]
INSERT INTO @ListParam ([Value]) VALUES
('Alpha'),
('Bob''s Item');

DECLARE @Id INT = 7

SELECT *
FROM dbo.Users	WHERE UserId = @Id

[tushar-singh-spraxa]

@copilot formatSqlQueryForLog in lib/sql.js doesn't handle mssql.Table (TVP) parameters — it dumps them as JSON. Add detection via instanceof mssql.Table, then for TVPs generate executable T-SQL: DECLARE @name [schema].[type] using table.path, followed by INSERT INTO @name (col1, col2) VALUES (val1, val2) using table.columns for names and the existing stringifySqlValue for values — batch up to 100 rows per INSERT with multi-row VALUES. Mix TVP DECLARE+INSERT before scalar DECLARE lines. Add a test in tests/sql-log-format.test.js that creates an mssql.Table, passes it as a parameter, and asserts the output contains the type path and readable row values (not JSON).

[Copilot]

@copilot formatSqlQueryForLog in lib/sql.js doesn't handle mssql.Table (TVP) parameters — it dumps them as JSON. Add detection via instanceof mssql.Table, then for TVPs generate executable T-SQL: DE...

Implemented in commit 2c2023e.

formatSqlQueryForLog now detects TVPs via descriptor.value instanceof mssql.Table and emits executable TVP SQL before scalar DECLAREs:

• DECLARE @Param [schema].[Type] (from table.path)
• INSERT INTO @Param ([col...]) VALUES (...) with multi-row batching at 100 rows per INSERT

I also added tests in tests/sql-log-format.test.js that create real mssql.Table params and verify type path + readable row values are present (and not JSON blobs).

[Copilot]

Pull request overview

This PR improves MSSQL query logging by formatting logged queries as readable, executable multi-line SQL, including generated DECLARE statements for scalar parameters and expanded TVP (mssql.Table) parameters as DECLARE + batched INSERT statements. It updates the slow-query, threshold logger, and error logger paths to use the new formatter and adds targeted tests to validate the emitted log shape.

Changes:

• Added formatSqlQueryForLog to generate executable SQL log output (scalar params + TVP support with 100-row batching).
• Updated MSSQL slow-query, threshold logging (createQueryLogger), and error logging (runQuery catch) to emit formatted SQL.
• Added tests/sql-log-format.test.js to verify formatting behavior and usage across logging call sites.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
lib/sql.js	Adds SQL log formatting helpers and applies them to query duration, slow-query, and error logging paths.
tests/sql-log-format.test.js	Introduces coverage to validate the formatted SQL output (including TVPs and batching) and that all intended log sites use it.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.