Bug #70477 Playbook / Portal (RawURL in error not showing Hash)#178
Open
anishdwivedi-spraxa wants to merge 1 commit into
Open
Bug #70477 Playbook / Portal (RawURL in error not showing Hash)#178anishdwivedi-spraxa wants to merge 1 commit into
anishdwivedi-spraxa wants to merge 1 commit into
Conversation
Destructuring rawUrl from the log object and preferring it over req.referrer when setting the UrlReferrer query param.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HTTP log transport (pino-http-send) to capture a more complete URL (including hash fragments) by preferring a rawUrl field from the log payload when populating the UrlReferrer query parameter, addressing a Portal/Playbook reporting gap where the hash was not visible.
Changes:
- Destructure
rawUrlfrom the log payload (others) so it can be used explicitly. - Prefer
rawUrloverreq.referrerwhen setting theUrlReferrerquery param sent to the configured HTTP endpoint.
| queryParams.set("User Agent", req.userAgent || ""); | ||
| queryParams.set("Absolute Url", req.url || ""); | ||
| queryParams.set("UrlReferrer", req.referrer || ""); | ||
| queryParams.set("UrlReferrer", rawUrl || req.referrer || ""); |
durlabhjain
reviewed
Jun 15, 2026
durlabhjain
left a comment
durlabhjain
left a comment
Owner
There was a problem hiding this comment.
What's the point of this rawUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destructuring rawUrl from the log object and preferring it over req.referrer when setting the UrlReferrer query param.