WIP: #49 handle notify data set changed and update internal list#54
WIP: #49 handle notify data set changed and update internal list#54
Conversation
1a4a0df to
e33e5c7
Compare
There was a problem hiding this comment.
The refreshDataSetInternal seems to have a bug, in the else if (mItemList.size() > getItemCount) i think you are supposed to remove items from the list not add them am I right?
My fix just flushes mItemList and repopulate with new data i did this because i have a custom filter option where i move and filter items on the fly on my recycler view i that case i think its best to just clear the list and repopulate
Or do you have another idea?
|
@smarques84 Do the changes here if you can (not sure about the permissions) and add some test otherwise i'm not sure when i'll be ablet to pick this up. |
707662c to
a2b60de
Compare
|
I'm gonna resume this PR, i've added the implementation as you said for just refreshing the dataset with a custom |
|
Can we get an official look at this so it can be merged? |
b62f181 to
97adeef
Compare
This is WIP PR that is going to close #49.
I'll need to add unit tests and instrumentation tests and i'll be ready. The functionality is already there.
@smarques84