Skip to content

feat: Tool Tibial Plateau Angle#568

Merged
laura-borghesi-lum00n merged 6 commits into
masterfrom
feat-TPA-tool
May 4, 2026
Merged

feat: Tool Tibial Plateau Angle#568
laura-borghesi-lum00n merged 6 commits into
masterfrom
feat-TPA-tool

Conversation

@laura-borghesi-lum00n

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a specialized annotation tool designed for veterinary orthopedic measurements. The new tool, named TPAAnnotationTool, enables precise calculation of the Tibial Plateau Angle by guiding the user through a structured drawing process of key anatomical lines. This enhancement provides a valuable diagnostic capability within the imaging platform.

Highlights

  • New TPA Annotation Tool: Introduced a new TPAAnnotationTool for measuring the Tibial Plateau Angle (TPA) in medical images. This tool guides users through a three-step process to define anatomical lines and automatically calculates the TPA angle.
  • Three-Step Measurement Workflow: The TPA tool implements a specific workflow: first, drawing the Functional Tibial Axis (FTA); second, drawing the Medial Tibial Plateau Line (MTP); and finally, automatically computing a Reference Line and the TPA angle based on these inputs.
  • Tool Integration: The newly created TPAAnnotationTool has been integrated into the application's default toolset, making it available for use within the imaging interface.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🔍 Cypress Test Results

Status: ✅ All tests passed
Pass Rate: 100.00%
Total Tests: 32
Passed: 32
Failed: 0
Pending/Skipped: 0
Duration: 67.52s

📊 Test Suite Details

Suite Status Pass % Total Passed Failed Pending
Root > Testing the base.html functionalities 100.00% 13 13 0 0
Root > Larvitar DICOM Viewer 100.00% 1 1 0 0
Root > Larvitar - Default Tools Example 100.00% 3 3 0 0
Root > Larvitar DSA Rendering 100.00% 2 2 0 0
Root > Larvitar ECG Rendering 100.00% 6 6 0 0
Root > Larvitar Multiframe Rendering 100.00% 4 4 0 0
Root > Larvitar DICOM PDF Rendering 100.00% 1 1 0 0
Root > Testing the 4d.html functionalities 100.00% 2 2 0 0

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🧪 Type Coverage

93.43%

(20770 / 22230)

███████████████████░ 93.43%
Target: 90%

Top hotspots (untyped occurrences)

File Uncovered
imaging/imageRendering.ts 240
imaging/imageUtils.ts 142
imaging/parsers/nrrd.js 138
imaging/imageTools.ts 112
imaging/imageParsing.ts 100

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new TPAAnnotationTool with functionality for measuring Tibial Plateau Angle. The implementation covers drawing functional tibial axis, medial tibial plateau line, and a reference line, along with calculating the TPA angle. The changes also correctly integrate the new tool into the default.ts configuration. However, there are several areas for improvement related to maintainability, correctness, and efficiency, primarily concerning magic numbers, data type consistency, and code duplication.

Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts Outdated
Comment thread imaging/tools/custom/TPAAnnotationTool.ts Outdated
Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts Outdated
Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts
Comment thread imaging/tools/custom/TPAAnnotationTool.ts Outdated
@laura-borghesi-lum00n laura-borghesi-lum00n marked this pull request as ready for review March 19, 2026 10:47
@daron1337

Copy link
Copy Markdown
Member

Check auto-review

@laura-borghesi-lum00n laura-borghesi-lum00n changed the title feat: Tool Vertebral Heart Score feat: Tool Tibial Plateau Angle Mar 26, 2026
@laura-borghesi-lum00n laura-borghesi-lum00n merged commit 362cba7 into master May 4, 2026
1 check passed
@laura-borghesi-lum00n laura-borghesi-lum00n deleted the feat-TPA-tool branch May 4, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants