Support changing channels via ADB and other changes.#7
Open
gigem wants to merge 8 commits into
Open
Conversation
added 8 commits
August 14, 2023 21:10
Allow passing in the desired channelId as an extra string in the
activity intent using ADB. Also use singleTask launch mode in order
to prevent multiple instances of the app running simultaneously. The
following is an example invocation using the new functionality.
adb shell am start \
-n com.workaround.spectv/com.workaround.spectv.MainActivity \
-e channelId 32645
Either I was mistaken that it ever worked or Spectrum recently stopped allowing it. It's probably the former.
The history.back is not needed in this case and just slows things down by resetting the player before loading the new URL.
Wait for the Continue button in the Still There? popup to appear and click it to keep the stream playing. This version works but has the disadvantage that it polls for an event that happens very, very, infrequently. A better version will be committed shortly.
Wait for the Continue button in the Still There? popup to appear and click it to keep the stream playing. This version works better than the previous one. It creates a MutationObserver to wait for changes to the HTML and only checks for the Continue button in the changed subtrees when they occur. Consequently, there is no polling and in testing so far, the popup is dismissed before it is even visible.
dwineknott
approved these changes
Sep 4, 2024
dwineknott
approved these changes
Sep 4, 2024
dwineknott
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following features: