Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

weth-pusd constants #63

Open
samweinberg23 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

weth-pusd constants #63

samweinberg23 wants to merge 3 commits into from

Conversation

@samweinberg23
Copy link
Contributor

@samweinberg23 samweinberg23 commented Jul 30, 2020 •
edited
Loading

  • set all fees to 100 basis points
  • added weth-pusd pair but not market

BrendanChou
BrendanChou reviewed Jul 30, 2020
View reviewed changes
dydx/constants.py Outdated
Comment on lines 67 to 69
FEE_LARGE_WETH_PUSD = Decimal(100) * FROM_BIPS
FEE_SMALL_WETH_PUSD = Decimal(100) * FROM_BIPS
FEE_MAKER_WETH_PUSD = Decimal(100) * FROM_BIPS
Copy link

@BrendanChou BrendanChou Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new variables are never used, instead you can modify the get_limit_fee() function

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BrendanChou BrendanChou BrendanChou left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samweinberg23 @BrendanChou