Skip to content

Changing primary variant dont show correct price #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frederik5480 merged 1 commit into from
May 27, 2025
Merged

Changing primary variant dont show correct price #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Ecommerce.DynamicwebLiveIntegration/Dynamicweb.Ecommerce.DynamicwebLiveIntegration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Version>10.4.23</Version>
<Version>10.4.24</Version>
<AssemblyVersion>1.0.0.0</AssemblyVersion>
<Title>Live Integration</Title>
<Description>Live Integration</Description>
Expand Down
19 changes: 4 additions & 15 deletions src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ private static List<PriceProductSelection> GetProductsForRequest(Settings settin
// Check for existence of the given products in the Cache
List<PriceProductSelection> productsForRequest = new List<PriceProductSelection>();
bool getProductInformationForAllVariants = settings.GetProductInformationForAllVariants;
bool showVariantDefault = SystemConfiguration.Instance.GetBoolean("/Globalsettings/Ecom/Product/ShowVariantDefault");

foreach (var productWithQuantity in products)
{
Expand Down Expand Up @@ -317,24 +318,12 @@ private static List<PriceProductSelection> GetProductsForRequest(Settings settin
}
}
}
else

if (showVariantDefault)
{
if (!string.IsNullOrEmpty(product.VariantId) && !string.IsNullOrEmpty(product.DefaultVariantComboId) && !string.Equals(product.VariantId, product.DefaultVariantComboId)
&& GetFilteredVariants(new List<Product>() { product }).Count != 0)
{
productIdentifier = ProductProvider.GetProductIdentifier(settings, product, productWithQuantity.UnitId);
if (!ResponseCache.IsProductInCache(productCacheLevel, productIdentifier, context.User, doCurrencyCheck ? context.Currency : null))
{
if (ProductProvider.IsLivePriceEnabledForProduct(product) && product.HasIdentifier(settings))
{
productsForRequest.Add(product.GetPriceProductSelection(productWithQuantity.Quantity, productWithQuantity.UnitId));
}
}
}
product = ProductProvider.GetProductFromVariantComboId(product, logger);
}

product = ProductProvider.GetProductFromVariantComboId(product, logger);

if (string.IsNullOrEmpty(product.VariantId) || GetFilteredVariants(new List<Product>() { product }).Count != 0)
{
productIdentifier = ProductProvider.GetProductIdentifier(settings, product, productWithQuantity.UnitId);
Expand Down
11 changes: 7 additions & 4 deletions src/Dynamicweb.Ecommerce.DynamicwebLiveIntegration/Products/ProductPriceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Cache;
using Dynamicweb.Configuration;
using Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Cache;
using Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Configuration;
using Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Connectors;
using Dynamicweb.Ecommerce.DynamicwebLiveIntegration.Extensions;
Expand Down Expand Up @@ -30,10 +31,12 @@ public class ProductPriceProvider : PriceProvider, IPriceInfoProvider

List<PriceProductSelection> products = new List<PriceProductSelection>();

Product changedProduct = ProductManager.ProductProvider.GetProductFromVariantComboId(product.Product, logger);
products.Add(changedProduct.GetPriceProductSelection(product.Quantity, product.UnitId));
bool showVariantDefault = SystemConfiguration.Instance.GetBoolean("/Globalsettings/Ecom/Product/ShowVariantDefault");

Product productForRequest = showVariantDefault ? ProductManager.ProductProvider.GetProductFromVariantComboId(product.Product, logger) : product.Product;
products.Add(productForRequest.GetPriceProductSelection(product.Quantity, product.UnitId));
// After GetProductFromVariantComboId the variantId is empty or other product is returned so new identifier must be generated
productIdentifier = ProductManager.ProductProvider.GetProductIdentifier(settings, changedProduct, product.UnitId);
productIdentifier = ProductManager.ProductProvider.GetProductIdentifier(settings, productForRequest, product.UnitId);

bool fetchedProductInfo = ProductManager.FetchProductInfos(products, context, settings, logger, true, SubmitType.Live);
if (fetchedProductInfo &&
Expand Down
Loading