Add files API by djeebus · Pull Request #1893 · e2b-dev/infra

djeebus · 2026-02-11T17:18:30Z

TODO:

combine the "token" endpoint functionality into "get volume"
add tests to entryInfo helper functions
retry orchestrator errors that indicate "volume type unknown"
sdk integration testing
assign files "volume" user and "volume" group by default
centralize tryParseUUID, refactor to use it
add rotation support
asymmetric by default
if volume type unknown error occurs, only log once, not once per orchestrator

later:

follow up later with jwks
unify delete function

Note

High Risk
Introduces new token-signing configuration and changes how persistent volumes are provisioned/mounted and accessed (Filestore/NFS + proxy pathing), which can impact security and data availability if misconfigured. Also adds substantial new orchestrator I/O surface area that needs careful validation and rollout.

Overview
Adds a first-pass “files API” for volumes by extending the orchestrator volume service with filesystem-style operations (stat/list/create/update/delete for files and dirs) and wiring the API to mint and return a signed per-volume content token on volume create/get responses. Deployment/IaC is updated to support persistent volume types on GCP (new Filestore-backed mounts, configurable NFS version, and propagated volume/token env vars), and the NFS proxy is hardened and reworked to mount by teamID/volumeID with improved jail/path validation and expanded e2e coverage.

^{Written by Cursor Bugbot for commit 6d92ec6. This will update automatically on new commits. Configure here.}

# Conflicts: # packages/api/internal/api/api.gen.go

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 427d2ec5d6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/api/internal/handlers/volumecontent_dirlist.go

spec/openapi.yml

mishushakov

I am thinking we can find some way to unify Volume entries + Dir entries, so it's same struct regardless if it's from stat or from list

spec/openapi.yml

# Conflicts: # packages/api/internal/api/api.gen.go

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

iac/provider-gcp/volume_content_signing_key.tf

iac/provider-gcp/nomad/main.tf

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/.env.local

packages/api/internal/handlers/volume_util.go

packages/orchestrator/internal/volumes/service.go

# Conflicts: # iac/modules/job-orchestrator/main.tf # iac/provider-gcp/nomad/main.tf

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/internal/cfg/model.go

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/internal/cfg/model.go

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/orchestrator/internal/volumes/service.go

packages/api/.env.local

packages/api/internal/handlers/volume_util.go

packages/orchestrator/internal/nfsproxy/jailed/fs.go

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/.env.local

packages/api/internal/handlers/volume_util.go

packages/api/internal/handlers/volume_create.go

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/Makefile

packages/api/internal/handlers/volume_util.go

packages/orchestrator/internal/volumes/service.go

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/internal/handlers/volume_util.go

dobrac

lgtm!

packages/api/Makefile

models changed

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/internal/handlers/volume_create.go

packages/api/internal/handlers/volume_util.go

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/api/internal/handlers/volume_util.go

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

packages/orchestrator/internal/volumes/file_create.go

packages/api/internal/handlers/volume_util.go

djeebus added 2 commits February 11, 2026 09:07

files

545a61f

update contracts

427d2ec

djeebus requested review from ValentaTomas, dobrac and jakubno as code owners February 11, 2026 17:18

e2b-request-same-site-reviewers bot assigned levb Feb 11, 2026

Merge remote-tracking branch 'origin/main' into add-files-api

967fa3e

# Conflicts: # packages/api/internal/api/api.gen.go

djeebus marked this pull request as draft February 11, 2026 17:20

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

packages/api/internal/handlers/volumecontent_dirlist.go Outdated Show resolved Hide resolved

github-actions bot and others added 3 commits February 11, 2026 17:22

chore: auto-commit generated changes

e96db83

Merge remote-tracking branch 'origin/main' into add-files-api

c0402ce

progress?

442ff0d

mishushakov reviewed Feb 12, 2026

View reviewed changes

spec/openapi.yml Outdated Show resolved Hide resolved

Merge branch 'main' into add-files-api

072c1d8

mishushakov reviewed Feb 12, 2026

View reviewed changes

spec/openapi.yml Outdated Show resolved Hide resolved

mishushakov and others added 4 commits February 12, 2026 17:14

Merge branch 'main' into add-files-api

153985a

progress!

c413ecb

Merge remote-tracking branch 'origin/add-files-api' into add-files-api

61d2458

chore: auto-commit generated changes

dfc565d

mishushakov reviewed Feb 12, 2026

View reviewed changes

djeebus added 10 commits February 12, 2026 13:47

improve api methods

eb25735

api tweaks and implementation

42eb62c

rename some things

2a0c9e5

Merge remote-tracking branch 'origin/main' into add-files-api

0b43a4a

add error for invalid path

898557b

Merge remote-tracking branch 'origin/main' into add-files-api

f0b582c

# Conflicts: # packages/api/internal/api/api.gen.go

add recursive flag when deleting directory

a22147e

linting

57a781c

fix unit tests

502a16e

sigh.

b2dc9c6

Merge branch 'main' into add-files-api

e41ffb1

cursor bot reviewed Mar 4, 2026

View reviewed changes

iac/provider-gcp/volume_content_signing_key.tf Show resolved Hide resolved

iac/provider-gcp/nomad/main.tf Outdated Show resolved Hide resolved

linting, better model

f950ba6

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/.env.local Outdated Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

packages/orchestrator/internal/volumes/service.go Show resolved Hide resolved

dobrac added the feature New feature label Mar 4, 2026

Merge remote-tracking branch 'origin/main' into add-files-api

4ee9c2c

# Conflicts: # iac/modules/job-orchestrator/main.tf # iac/provider-gcp/nomad/main.tf

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/internal/cfg/model.go Show resolved Hide resolved

chore: auto-commit generated changes

a192bff

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/internal/cfg/model.go Show resolved Hide resolved

djeebus added 4 commits March 4, 2026 10:03

wrong env var name

addfb99

finish renaming vars

61a8e68

add a token when creating a volume

5d976e9

Merge branch 'main' into add-files-api

6a18619

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/orchestrator/internal/volumes/service.go Show resolved Hide resolved

packages/api/.env.local Outdated Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

packages/orchestrator/internal/nfsproxy/jailed/fs.go Show resolved Hide resolved

chore: auto-commit generated changes

e8f4fed

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/.env.local Outdated Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

packages/api/internal/handlers/volume_create.go Show resolved Hide resolved

some code clean up, deployment

ef4f4c5

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/Makefile Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

packages/orchestrator/internal/volumes/service.go Show resolved Hide resolved

chore: auto-commit generated changes

5cbe027

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

dobrac approved these changes Mar 4, 2026

View reviewed changes

packages/api/Makefile Show resolved Hide resolved

djeebus added 2 commits March 4, 2026 14:08

fix assertion

2c1515a

models changed

linting

5cb8727

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/internal/handlers/volume_create.go Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

return "unknown volume type" when all nodes return it

b87b60b

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

only send back unknown when we've received at least one

6d92ec6

cursor bot reviewed Mar 4, 2026

View reviewed changes

packages/orchestrator/internal/volumes/file_create.go Show resolved Hide resolved

packages/api/internal/handlers/volume_util.go Show resolved Hide resolved

djeebus merged commit 926ced6 into main Mar 4, 2026
36 checks passed

djeebus deleted the add-files-api branch March 4, 2026 22:58

Conversation

djeebus commented Feb 11, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mishushakov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dobrac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

djeebus commented Feb 11, 2026 •

edited by cursor bot

Loading