Add versioning for accidental modification control#1944
Add versioning for accidental modification control#1944ValentaTomas wants to merge 10 commits intomainfrom
Conversation
…into storage-versioning
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| condition { | ||
| # Delete non-current versions immediatelly. | ||
| # This triggers the soft-delete policy, so objects are then deleted after another 10 days. | ||
| days_since_noncurrent_time = 0 |
There was a problem hiding this comment.
I think it is better to immediately delete the noncurrent (modified/deleted objects when versioning is enabled), because then we can see all the modified/deleted in one place as opposed to having it split between noncurrent+live and soft deleted views, which could get confusing if we are trying to restore things.
|
I'm waiting to check if the noncurrent object gets soft deleted after some unspecified time as even with 0 the deletion does not seem to be instant. |
Any update here? |
|
After cca day and something it correctly moved all noncurrent to the soft delete. |
Note
Medium Risk
Changes GCS bucket versioning and lifecycle policies, which can affect retention, costs, and recoverability if misconfigured. Scope is limited to the
fc_template_bucketresource but impacts production storage behavior.Overview
Enables object versioning on the
fc_template_bucketand adds a lifecycle rule to delete non-current (archived) object versions immediately, relying on the existing 10-daysoft_delete_policyto provide a recovery window (withsend_age_if_zero = falseas a provider workaround). Review that the immediate noncurrent-version deletion plus versioning doesn’t unintentionally shorten retention expectations or increase storage/operations costs due to additional versions being created.Written by Cursor Bugbot for commit e59d228. This will update automatically on new commits. Configure here.