chore(orch): move firecracker version feature flag#2030
Draft
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| network.Egress.DeniedCidrs = []string{sandbox_network.AllInternetTrafficCIDR} | ||
| } | ||
|
|
||
| resolvedFCVersion := featureflags.ResolveFirecrackerVersion(ctx, s.featureFlags, req.GetSandbox().GetFirecrackerVersion()) |
There was a problem hiding this comment.
resolvedFCVersion may differ from req.GetSandbox().GetFirecrackerVersion() when node-specific overrides are active. However, SandboxFirecrackerVersionAttribute in the LD multi-context was already set to the incoming (API-resolved) version at line 74, before this resolution. Any other feature flags in this request that target on the sandbox's firecracker-version attribute will evaluate against the pre-orchestrator-resolved value rather than the version that will actually be used.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to change the firecracker version only for some commits and to do rolling update based on orchestrator nodes
Note
Medium Risk
Changes how the Firecracker binary version is selected during sandbox create/resume, which can impact runtime compatibility if the feature-flag mapping or version parsing is wrong. Risk is mitigated by falling back to the build-provided version when resolution fails.
Overview
This PR centralizes Firecracker version resolution behind
feature_flags.ResolveFirecrackerVersionand wires it into both API sandbox creation and orchestrator-side sandbox resume, enabling LaunchDarkly overrides based on a new orchestrator context that includes the node ID and source commit for rolling updates.Written by Cursor Bugbot for commit c2ad55f. This will update automatically on new commits. Configure here.