Skip to content

Harden BuildHomeBlocksDeps checkout ref resolution for stale/invalid branch inputs #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: dev/v6.x
Choose a base branch
from
Draft

Harden BuildHomeBlocksDeps checkout ref resolution for stale/invalid branch inputs #162

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b029c0
Initial plan
Copilot Jun 8, 2026
978dbd8
fix: fallback to current ref when workflow branch input is invalid
Copilot Jun 8, 2026
8bc341d
hardening: validate workflow ref input before checkout fallback
Copilot Jun 8, 2026
fe41fc8
chore: handle empty branch input in checkout ref resolver
Copilot Jun 8, 2026
c230cbd
fix: fail fast if checkout ref resolution produces empty ref
Copilot Jun 8, 2026
f362f47
refactor: use regex ref detection in checkout resolver
Copilot Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions .github/workflows/build_dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,33 @@ jobs:
BuildHomeBlocksDeps:
runs-on: ${{ inputs.platform }}
steps:
- name: Resolve checkout ref
id: resolve-ref
shell: bash
run: |
requested_ref="${{ inputs.branch }}"
fallback_ref="${{ github.ref }}"
repo_url="${{ github.server_url }}/${{ github.repository }}"

if [[ -z "${requested_ref}" ]]; then
echo "::warning::No branch/ref was provided; falling back to '${fallback_ref}'."
checkout_ref="${fallback_ref}"
elif [[ "${requested_ref}" =~ ^refs/ ]] && git check-ref-format "${requested_ref}"; then
checkout_ref="${requested_ref}"
elif git check-ref-format "refs/heads/${requested_ref}" && \
git ls-remote --exit-code --heads "${repo_url}" "${requested_ref}" >/dev/null 2>&1; then
checkout_ref="${requested_ref}"
else
echo "::warning::Requested branch/ref '${requested_ref}' is invalid or was not found in ${{ github.repository }}; falling back to '${fallback_ref}'."
checkout_ref="${fallback_ref}"
fi

echo "checkout_ref=${checkout_ref}" >> "${GITHUB_OUTPUT}"

- name: Retrieve Code
uses: actions/checkout@v4
with:
ref: ${{ inputs.branch }}
ref: ${{ steps.resolve-ref.outputs.checkout_ref }}
if: ${{ inputs.testing == 'True' }}

- name: Check Code Formatting
Expand Down Expand Up @@ -132,7 +155,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: eBay/HomeBlocks
ref: ${{ inputs.branch }}
ref: ${{ steps.resolve-ref.outputs.checkout_ref }}
if: ${{ inputs.testing == 'False' }}

- name: Setup Conan
Expand Down