-
Notifications
You must be signed in to change notification settings - Fork 23
[23929] Add tests for empty dispose messages #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emiliocuestaf
wants to merge
4
commits into
main
Choose a base branch
from
feature/forward-not-alive-status-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+977
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
==========================================
- Coverage 31.14% 30.24% -0.90%
==========================================
Files 16 16
Lines 594 562 -32
Branches 321 298 -23
==========================================
- Hits 185 170 -15
+ Misses 213 205 -8
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
raulojeda22
requested changes
Jan 14, 2026
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/CMakeLists.txt
Outdated
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocalInstances.cpp
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocalInstances.cpp
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocalInstances.cpp
Outdated
Show resolved
Hide resolved
ddsrouter_core/test/blackbox/ddsrouter_core/dds/local/DDSTestLocalInstances.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
raulojeda22
approved these changes
Jan 14, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI tests and devutils pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to check that dispose messages with empty payload are correctly forwarded in the DDS Pipe/Router ecosystem.
This PR depends on eProsima/DDS-Pipe#172 and must be merged after it!