Skip to content

Conversation

@MarkMelotto
Copy link
Contributor

No description provided.

@MarkMelotto MarkMelotto requested a review from RolfHut July 15, 2025 10:50
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -112,7 +112,7 @@
"1. This allows us to demonstrate how to generate forcing data for any model from ERA5 (working on ERA5Land) and from CMIP data\n",
Copy link
Contributor

@RolfHut RolfHut Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would either add the csv file that used to be on data/datasets/egu/calibration/ to the repo and load from that, or do a trick like with the forcing where you provide two options: from file or hand picked?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It serves as a tutorial so I think it is fine to keep it like this, this way it should always work the first time around

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

{
"name": "stdout",
"output_type": "stream",
"text": [
Copy link
Contributor

@RolfHut RolfHut Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a markdown cell above with a short explenation what this notebook does?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good one :)

@MarkMelotto MarkMelotto requested a review from RolfHut July 15, 2025 13:19
@MarkMelotto
Copy link
Contributor Author

@RolfHut added a short description

Copy link
Contributor

@RolfHut RolfHut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@RolfHut RolfHut merged commit c6ab3f3 into main Jul 16, 2025
9 checks passed
@RolfHut RolfHut deleted the fix-hbv-workflow branch July 16, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants