Conversation
* remove EoL python and django versions * enable PyPI trusted publisher * remove travis CI config * update classifiers
.github/workflows/packaging.yml
Outdated
| check: | ||
| name: Format, lint and type checks |
There was a problem hiding this comment.
Can you say a little about the rationale of condensing these into a single job? I generally prefer to see ✅ or 🔴 for a specific task failure rather than having to click into the job to find out which, if that makes sense.
If to avoid repetitiveness, perhaps we could use YAML anchors or something.
There was a problem hiding this comment.
Good point about visibility - I was mostly worried about duplication.
I switched the checks to use a matrix strategy that pulls in the tox configs from pyproject.toml: tool.tox.env.{typecheck,format,lint}, similar to how it was done for the tests. That way, running the checks locally will work exactly the same way as in the CI, and they show up as separate jobs in the Github UI.
re-uses the tox.tool.env.{lint,format,typecheck} config
from pyproject.toml
daneah
left a comment
daneah
left a comment
There was a problem hiding this comment.
This looks great; I'll merge this and after doing a few other activities will do a new version release to test out the trusted publishing.
2 participants
This PR updates the Github Actions (#26):
pyprojectI created a clean PR with your review comments instead of [#29]. My testing of Github Actions was a bit messy, sorry!
See Github Action run for a PR and for a release (publishing is triggered but fails as expected because trusted publisher is not configured on PyPI side).