feat: removed panic from darwin read error#24
Open
alexanderturner wants to merge 1 commit intoebfe:masterfrom
Open
feat: removed panic from darwin read error#24alexanderturner wants to merge 1 commit intoebfe:masterfrom
alexanderturner wants to merge 1 commit intoebfe:masterfrom
Conversation
Owner
|
I don't see how this fixes the described issue. The changed code only panics if an unknown Protocol was passed to scardTransmit which is entirely up to the caller. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darwin would panic if
scardTransmitfailed. This would occur during partial reads, such as if someone removes the card too quickly during a tap, resulting in applications implementing this to panic. This is undesired behaviour. I've amended this to returnSCARD_F_INTERNAL_ERRORfrom PCSC instead, which I think is suitable.Please let me know if there are any other suggestions to remediate this