Postingflags by shawnpringle · Pull Request #1137 · ecency/ecency-vision

shawnpringle · 2022-12-02T01:28:55Z

I'll be adding these features:
show whether a post was self-voted, how its reward will be split, and when to display what the reward limit is.

Sometimes it is interesting to some to see whether the user has self-voted a post. Whether they are powering up 100% or whether they have limited their payout to some small value.

These are set in the site wide defaults file:
"showSelfVote": true, "showRewardSplit": true, "lowRewardThreshold": 1000000000
For example, if you set lowRewardThreshold to 1000, it wont show unless the post is restricted to 1000 HBD or to some other lower value.

See also: https://www.proofofbrain.blog/hive-150329/@leprechaun/show-self-vote-maximum-payout-hive-150329

…defaults file

…reshold, but preference dialog doesn't get updated.

…decimal placs to maximum HBD display

src/common/components/comment/__snapshots__/index.spec.tsx.snap

src/common/components/entry-list-item/index.tsx

dkildar · 2022-12-08T07:12:17Z

src/common/components/entry-list-item/index.tsx

    const cls = `entry-list-item ${promoted ? "promoted-item" : ""} ${global.filter}`;

+    const self_vote_entry = entry.active_votes.find((x) => x.voter == entry.author);
+    const self_vote = self_vote_entry ? self_vote_entry.rshares : false;


const selfVote = self_vote_entry?.rshares ?? false;

dkildar · 2022-12-08T07:12:52Z

src/common/components/entry-list-item/index.tsx

+    const self_vote_entry = entry.active_votes.find((x) => x.voter == entry.author);
+    const self_vote = self_vote_entry ? self_vote_entry.rshares : false;
+    const hp_portion = 100 * (1 - entry.percent_hbd / 20000);
+    const max_payout: number = parseFloat(entry.max_accepted_payout);


No need extra number

dkildar · 2022-12-08T07:14:06Z

src/common/components/entry-list-item/index.tsx

+                <div className="app" title={app}>
+                  <Tsx k="entry.via-app" args={{ app: appShort }}>
+                    <a href="/faq#source-label" />
+                  </Tsx>


I guess <a href="/faq#source-label">{_t('entry.via-app', { app: appShort })}</a> much easier

dkildar · 2022-12-08T07:15:35Z

src/common/components/entry-read-time/index.tsx

+    // @ts-ignore
+    (x) => x.voter == entry.author
+  );
+  const self_vote = self_vote_entry ? true : false;


const selfVote = !!selfVoteEntry

dkildar · 2022-12-08T07:16:27Z

src/common/components/preferences/index.tsx

+  showSelfVoteChanged = (e: React.ChangeEvent<typeof FormControl & HTMLInputElement>) => {
+    const { setShowSelfVote } = this.props;
+    const { value } = e.target;
+    console.log(value);


Unnecessary log

dkildar · 2022-12-08T07:17:03Z

src/common/components/preferences/index.tsx

+    try {
+      setLowRewardThreshold(JSON.parse(value));
+    } catch (e) {
+      console.log(value, "Couldn't get it done boss");


We have a error function that will show an alert on the bottom right side of viewport. Please use it instead

Error message not meaningful

dkildar · 2022-12-08T07:18:05Z

src/common/components/preferences/index.tsx

    }
+    this.showSelfVoteChanged = this.showSelfVoteChanged.bind(this);
+    this.showRewardSplitChanged = this.showRewardSplitChanged.bind(this);
+    this.lowRewardThresholdChanged = this.lowRewardThresholdChanged.bind(this);


Why you did this? Arrow functions already have a current context

shawnpringle · 2022-12-08T13:18:05Z

Hello! Thanks for the feedback. The SNAP files are generated by the yarn test process. So, yes it seems to me that the Object text is unnecessary but will the tests work if you remove them? You're right, arrow functions already have the context put in. I'll also change these to "camelCase". Thank you again for your valuable input.

…

On Thu, Dec 8, 2022 at 4:18 AM Ildar Timerbaev ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/common/components/preferences/index.tsx <#1137 (comment)> : > @@ -114,6 +145,10 @@ export class Preferences extends BaseComponent<Props, State> { if (use_system_theme) { theme = "system"; } + this.showSelfVoteChanged = this.showSelfVoteChanged.bind(this); + this.showRewardSplitChanged = this.showRewardSplitChanged.bind(this); + this.lowRewardThresholdChanged = this.lowRewardThresholdChanged.bind(this); Why you did this? Arrow functions already have a current context — Reply to this email directly, view it on GitHub <#1137 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAUVO5MJN63A56FI3Z2NOYDWMGDTRANCNFSM6AAAAAASRMWPPY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

…baev

feruzm · 2023-01-31T17:55:59Z

@shawnpringle I would prefer bit discreet design to show these info. Can you check mobile view in posts, there we have i info icon that shows read time and word count, could we show these details inside that type of popover?!
Idea of simplicity is to keep page from too much information being shown to new users. For many people these information has less value, imo. What do you think?

Also to discuss further fundamental of these features, here are few arguments:

self voted info - why we need to show this info to reader, people post their content usually do like it! This feature creates false mentality that it is wrong.
reward split - it is already shown when you hover on $ values, isn't it.
reward limit - also shown when you hover on $ if it is different than default value

leprechaun and others added 9 commits November 28, 2022 19:04

* allow showing extra post information according to flags set in the …

fe7fd25

…defaults file

* connecting new postingflags to the preferences pane.

a76a874

* progress: able to set showSelfVote, showRewardSplit and lowRewardTh…

6b10ca8

…reshold, but preference dialog doesn't get updated.

* fixed bugs: now the settings page updates

d532713

* test updates

881f351

* add tests

b2a13eb

* merge

cd01830

* add spacing around via frontend line in entry list item. Added all …

ddd882e

…decimal placs to maximum HBD display

* added control of showing which front end was used in entry-items

36344af

dkildar reviewed Dec 8, 2022

View reviewed changes

src/common/components/comment/__snapshots__/index.spec.tsx.snap Show resolved Hide resolved

dkildar reviewed Dec 8, 2022

View reviewed changes

src/common/components/entry-list-item/index.tsx Outdated Show resolved Hide resolved

dkildar reviewed Dec 8, 2022

View reviewed changes

* use camel case and other small improvements. Thank you Mr/Ms. Timer…

b07cb17

…baev

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Postingflags#1137

Postingflags#1137
shawnpringle wants to merge 10 commits intoecency:developmentfrom
steemfiles:postingflags

shawnpringle commented Dec 2, 2022

Uh oh!

Uh oh!

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

dkildar Dec 8, 2022

Uh oh!

shawnpringle commented Dec 8, 2022 via email

Uh oh!

feruzm commented Jan 31, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

shawnpringle commented Dec 2, 2022

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnpringle commented Dec 8, 2022 via email

Uh oh!

feruzm commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feruzm commented Jan 31, 2023 •

edited

Loading