Revert 55c95c0 (#50) #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch addressed a specific net-tools-1.60 problem: attempt to access a socket before it is actually opened. This does not happen in recent versions, so the patch is more harmful than useful, as it could hide a real problem, if it happens. For more see ecki#32 (comment)
ecki
reviewed
Sep 8, 2025
| skfd = get_socket_for_af(AF_INET); | ||
| if (skfd < 0) { | ||
| fprintf(stderr, _("warning: no inet socket available: %s\n"), | ||
| strerror(errno)); |
Owner
There was a problem hiding this comment.
Btw I am not sure strerror() works here as getsocketforaf does no syscall, but let’s accept the revert and change it afterwards (or maybe store the error in the fd field)
ecki
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch addressed a specific net-tools-1.60 problem: attempt to access a socket before it is actually opened. This does not happen in recent versions, so the patch is more harmful than useful, as it could hide a real problem, if it happens.
For more see
#32 (comment)