Skip to content

Conversation

@dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Jan 6, 2026

What does this PR do?

It fixes incorrect wait timeout when run Smoke test with empty password value, like https://github.com/che-incubator/che-code/actions/runs/20744835965/job/59559776902

          ▼ DexLoginPage.waitDexLoginPageDisappearance
            ‣ DriverHelper.waitDisappearance - By(css selector, .dex-container)
            ‣ DriverHelper.waitDisappearanceBoolean - By(css selector, .dex-container)
            ‣ DriverHelper.isVisible - By(css selector, .dex-container)
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.isVisible - By(css selector, .dex-container)
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.isVisible - By(css selector, .dex-container)
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.isVisible - By(css selector, .dex-container)
            ‣ DriverHelper.wait - (1000 milliseconds)
...
(This repeats for more than one hour.)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#23701

How to test this PR?

Run smoke test in che-code repo with empty password value.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

--
Assisted-by: Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants