Update and consume third-party content #648
Conversation
No changes, but reforatted with current version of PDE This makes future edits easier as there will be no unrelated edits on the file.
These don't hurt anything to exist, but getting rid of them removes a warning.
Will parent commits moving or removing dependencies this commit is the completion of eclipse-embed-cdt#453 Fixes eclipse-embed-cdt#453
To be able to use location type Maven in target file we need a more recent Tycho version. Instead of updating to latest (5.x) version of Tycho, we limit to 3.x version so that we can maintain compatibility with older Eclipse target platform. Embed CDT uses 2020-09 as target platform. The build requires a newer Java version, but the built artifacts continue to run in Java11+ on Eclipse 2020-09+. Fixes eclipse-embed-cdt#646
|
@ilg-ul LMK if this looks good to you - without any objections I will merge and build a milestone for SimRel sometime Mon-Wed this week. There is a version bump that needs to happen before then AFAICT - because I haven't changed any Eclipse or Java version dependencies, we can do a fairly minimal version bump, e.g. 6.6.1 -> 6.7.0 |
ilg-ul
left a comment
ilg-ul
left a comment
There was a problem hiding this comment.
Wow! You fixed a lot of things and probably brought it in line with the latest Eclipse build details.
I don't understand most of the details, but I have no objections.
|
Please let me know when you have a set of Mac binaries that I can test. |
As we consume directly from Maven Central for third-party dependencies we need to resign content with PGP to allow installation without signing errors. Note that this only works for recent-ish versions of Eclipse. Installing in older versions will cause unsigned content warnings. Users are recommended to use latest/recent Eclipse versions to be fully supported and ISVs are responsible to to maintain and update as needed.
We need Java 11 (for its JDK) and Java 21 for build tools.
jonahgraham
force-pushed
the
third-party
branch
from
dd6d545 to
4f2480a
Compare
It is ready as a the develp p2 site now: https://download.eclipse.org/embed-cdt/builds/develop/p2/ I am working on getting this published as a release candidate (under https://download.eclipse.org/embed-cdt/release-candidates/) and contributing it to SimRel. I have tested the p2 repo by installing it in:
And by updating Eclipse 2025-12 for Embedded C/C++ Developers. PGP signing changes
PGP signing changesIt is expected that in recent Eclipse's you will be asked if you trust the PGP content for the third-party code: 
This dialog does not appear if installing from SimRel or Oomph installer and does not appear when using the Eclipse IDE For Embedded C/C++ Developers download. In older Eclipse (e.g. the 2020-09 version that I tested with) those versions don't know about PGP keys, so you get this instead about third-party content: 
|
|
I did my usual quick test (instantiate the xPack Arm template and run a debug session via QEMU) and it passed. I would say that it is ok. Great work, thank you! |
|
Wonderful - thanks for the confirmation. |
|
Do you plan more updates to bring the plugins in line with the current build environments and a more recent CDT? |
No. I looked at changing the baseline to more recent and I didn't see any strong advantage to do that (it isn't broken, so don't "fix" it that way), especially in light of your concern raised in #646 (comment) |
|
Can we apply the PR changing the debug class? The other pending PRs? |
|
I have rebased #647 - if/once it builds successfully it can be merged. I can do another contribution to SimRel before EOD Wednesday so that 2026-03 M2 captures the most complete state of affairs. I commented on #547 As for other changes, I have not looked at them at all. I have no objection, but please request my review on any you want my input. They probably all need to be rebased before they build cleanly again. |
2 participants
This PR is an omnibus PR that updates the build to no longer embed third-party jars, allowing them to be updated in the "normal" flow of the rest of SimRel contributing projects.
Included is the needed updates to build with Java 21, but still produce Java 11 jars. As such we update to Tycho 3 which allows the needed new features, but still allows build and run against Eclipse 2020-09.
A future exercise could be to update to more recent Tycho and cutoff support for older Eclipse versions. ref: #646 (comment)
Fixes #646
Fixes #453